feat(fx, pickups, projectiles): remove dynamic lights to optimize performance and shader stability

src/fx.js

@@ -42,11 +42,8 @@ export function spawnMuzzleFlash() {
   quad.renderOrder = 11;
   G.scene.add(quad);
 
-  const light = new THREE.PointLight(0xfff2b0, 7, 6, 2);
-  light.position.copy(quad.position);
-  G.scene.add(light);
-
-  G.fx.flashes.push({ mesh: quad, light, life: CFG.fx.muzzleLife });
+  // Avoid dynamic lights to prevent shader recompiles
+  G.fx.flashes.push({ mesh: quad, light: null, life: CFG.fx.muzzleLife });
 }
 
 export function spawnMuzzleFlashAt(worldPos, color = 0xffc060) {
@@ -59,11 +56,7 @@ export function spawnMuzzleFlashAt(worldPos, color = 0xffc060) {
   quad.renderOrder = 11;
   G.scene.add(quad);
 
-  const light = new THREE.PointLight(color, 5.5, 5, 2);
-  light.position.copy(worldPos);
-  G.scene.add(light);
-
-  G.fx.flashes.push({ mesh: quad, light, life: CFG.fx.muzzleLife });
+  G.fx.flashes.push({ mesh: quad, light: null, life: CFG.fx.muzzleLife });
 }
 
 // Quick, subtle dust puff at a world position
@@ -97,12 +90,9 @@ export function spawnPortalAt(worldPos, color = 0xff5522, size = 1.1, life = 0.3
   flare.position.copy(worldPos);
   flare.lookAt(G.camera.position);
   flare.renderOrder = 12;
-  const light = new THREE.PointLight(color, 5, size * 6, 2);
-  light.position.copy(worldPos);
   G.scene.add(ring);
   G.scene.add(flare);
-  G.scene.add(light);
-  G.fx.portals.push({ ring, flare, light, life, maxLife: life, rot: Math.random() * Math.PI * 2 });
+  G.fx.portals.push({ ring, flare, light: null, life, maxLife: life, rot: Math.random() * Math.PI * 2 });
 }
 
 // Grenade explosion: additive glow sphere + shock ring + light
@@ -118,12 +108,9 @@ export function spawnExplosionAt(worldPos, radius = 6) {
   );
   ring.position.copy(worldPos);
   ring.rotation.x = Math.PI / 2;
-  const light = new THREE.PointLight(0xffa050, 9, radius * 3.5, 2);
-  light.position.copy(worldPos);
   G.scene.add(glow);
   G.scene.add(ring);
-  G.scene.add(light);
-  G.explosions.push({ glow, ring, light, life: 0.5, maxLife: 0.5 });
+  G.explosions.push({ glow, ring, light: null, life: 0.5, maxLife: 0.5 });
 }
 
 export function updateFX(delta) {
@@ -155,10 +142,8 @@ export function updateFX(delta) {
     m.life -= delta;
     m.mesh.material.opacity = Math.max(0, m.life / CFG.fx.muzzleLife);
     m.mesh.scale.setScalar(1 + (1 - m.life / CFG.fx.muzzleLife) * 0.6);
-    if (m.light) m.light.intensity = 3 + 4 * (m.life / CFG.fx.muzzleLife);
     if (m.life <= 0) {
       G.scene.remove(m.mesh);
-      if (m.light) G.scene.remove(m.light);
       m.mesh.geometry.dispose();
       if (m.mesh.material && m.mesh.material.dispose) m.mesh.material.dispose();
       G.fx.flashes.splice(i, 1);
@@ -191,12 +176,10 @@ export function updateFX(delta) {
     p.ring.scale.setScalar(s);
     p.flare.material.opacity = 0.15 + 0.45 * t;
     p.flare.scale.setScalar(s * 1.2);
-    if (p.light) p.light.intensity = 2 + 8 * t;
     p.flare.lookAt(G.camera.position);
     if (p.life <= 0) {
       G.scene.remove(p.ring);
       G.scene.remove(p.flare);
-      if (p.light) G.scene.remove(p.light);
       p.ring.geometry.dispose();
       p.flare.geometry.dispose();
       if (p.ring.material && p.ring.material.dispose) p.ring.material.dispose();
@@ -220,11 +203,9 @@ export function updateFX(delta) {
       e.ring.scale.setScalar(0.9 + (1 - t) * 2.6);
       e.ring.rotation.z += delta * 2.5;
     }
-    if (e.light) e.light.intensity = 2 + 10 * t;
     if (e.life <= 0) {
       if (e.glow) { G.scene.remove(e.glow); e.glow.geometry.dispose(); if (e.glow.material?.dispose) e.glow.material.dispose(); }
       if (e.ring) { G.scene.remove(e.ring); e.ring.geometry.dispose(); if (e.ring.material?.dispose) e.ring.material.dispose(); }
-      if (e.light) { G.scene.remove(e.light); }
       G.explosions.splice(i, 1);
     }
   }

src/pickups.js

@@ -4,12 +4,9 @@ import { CFG } from './config.js';
 import { getTerrainHeight } from './world.js';
 
 // Share orb material/geometry to avoid per-orb allocations
-const ORB_MAT = new THREE.MeshStandardMaterial({
-  color: 0x33ff66,
-  emissive: 0x1faa4e,
-  emissiveIntensity: 1.1,
-  roughness: 0.3,
-  metalness: 0.0
+// Switch to unlit Basic material so orbs glow without extra scene lights
+const ORB_MAT = new THREE.MeshBasicMaterial({
+  color: 0x5cff9a
 });
 const ORB_GEO = new THREE.SphereGeometry(0.12, 14, 12);
 
@@ -30,15 +27,10 @@ export function spawnHealthOrbs(center, count) {
     );
 
     const sphere = new THREE.Mesh(ORB_GEO, ORB_MAT);
-    sphere.castShadow = true;
+    sphere.castShadow = false;
     sphere.receiveShadow = false;
     group.add(sphere);
 
-    // Soft green point light for glow
-    const light = new THREE.PointLight(0x33ff66, 0.9, 6, 2);
-    light.position.set(0, 0.1, 0);
-    group.add(light);
-
     G.scene.add(group);
 
     // Initial outward + upward velocity (reduced to keep grouping tighter)
@@ -49,7 +41,7 @@ export function spawnHealthOrbs(center, count) {
 
     const orb = {
       mesh: group,
-      light,
+      light: null,
       pos: group.position,
       radius: 0.7, // pickup radius
       heal: 1,
@@ -112,7 +104,7 @@ export function updatePickups(delta) {
     // Visuals: rotation and glow pulse
     o.bobT += delta * 2.0;
     o.mesh.rotation.y += delta * 1.5;
-    if (o.light) o.light.intensity = 0.7 + 0.4 * (0.5 + 0.5 * Math.sin(o.bobT * 2.0));
+    // No dynamic light; keep unlit glow cheap
 
     // If settled, apply gentle bob around baseY
     if (o.state === 'settled') {

src/projectiles.js

@@ -80,8 +80,7 @@ export function spawnEnemyFireball(start, dirOrVel, asVelocity = false) {
   group.add(core);
   group.add(glow);
   group.add(ring);
-  const light = new THREE.PointLight(0xff5522, 7, 11, 2);
-  group.add(light);
+  // Avoid dynamic lights to keep shaders stable; rely on glow meshes
 
   group.position.copy(start);
   G.scene.add(group);
@@ -106,7 +105,7 @@ export function spawnEnemyFireball(start, dirOrVel, asVelocity = false) {
     core,
     glow,
     ring,
-    light,
+    light: null,
     osc: Math.random() * Math.PI * 2
   };
 
@@ -135,7 +134,7 @@ export function updateEnemyProjectiles(delta, onPlayerDeath) {
       p.mesh.scale.setScalar(pulse);
       if (p.ring) p.ring.rotation.z += delta * 3;
       if (p.glow) p.glow.material.opacity = 0.6 + Math.abs(Math.sin(p.osc * 1.3)) * 0.5;
-      if (p.light) p.light.intensity = 6 + Math.abs(Math.sin(p.osc * 2.1)) * 6;
+      // no dynamic light
     }
     p.life -= delta;